RFR: 8302057: Wrong BeanProperty description for JTable.setShowGrid [v3]

Alexey Ivanov aivanov at openjdk.org
Mon Aug 25 09:57:53 UTC 2025


On Mon, 25 Aug 2025 03:54:44 GMT, Renjith Kannath Pariyangad <rkannathpari at openjdk.org> wrote:

>> Hi Reviewers,
>> 
>> Updated the Bean Property description with meaningful string for JTable.setShowGrid.
>> 
>> Pleas review and let me know your suggestions if any.
>
> Renjith Kannath Pariyangad has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Updated string

Changes requested by aivanov (Reviewer).

src/java.desktop/share/classes/javax/swing/JTable.java line 1167:

> 1165:      */
> 1166:     @BeanProperty(description
> 1167:             = "Whether grid lines should be drawn around the cells.")

Suggestion:

            = "Whether grid lines are drawn around the cells.")

Just use Present tense? This way it aligns with javadoc that uses, “the table *draws* grid lines…”

-------------

PR Review: https://git.openjdk.org/jdk/pull/26857#pullrequestreview-3150731453
PR Review Comment: https://git.openjdk.org/jdk/pull/26857#discussion_r2297661825


More information about the client-libs-dev mailing list