RFR: 8360160: ubuntu-22-04 machine is failing client tests [v2]
Alexey Ivanov
aivanov at openjdk.org
Mon Aug 25 20:24:40 UTC 2025
On Mon, 25 Aug 2025 16:56:55 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:
>> Ubuntu machine has multiple failing java awt tests. When looking at the screenshots of the desktop when each test fails, a white square can be seen at the top-left of the desktop.
>>
>> <img width="803" height="344" alt="Screenshot 2025-08-20 at 10 06 37 AM" src="https://github.com/user-attachments/assets/52d023f6-18ff-46d4-98c4-e2e332ab6a03" />
>>
>> This seems to be similar to the white square that `FrameVisualTest.java` creates so the frame was not disposed of properly during this failure. I have tried re-creating this failure on Ubuntu 22.04, similar to the failure OS that this originally occurred on, to no avail. I ran this test individually, and with all of the listed failing tests back-to-back but all the tests pass as normal. This stabilization fix to the test attempts to prevent this in case it occurs again.
>
> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
>
> Replace setAutoDelay
test/jdk/java/awt/Frame/FrameVisualTest.java line 59:
> 57: gcs = GraphicsEnvironment.getLocalGraphicsEnvironment().getDefaultScreenDevice().getConfigurations();
> 58: robot = new Robot();
> 59: robot.waitForIdle();
There's nothing to wait for yet.
test/jdk/java/awt/Frame/FrameVisualTest.java line 90:
> 88: if (frames[index] != null) {
> 89: frames[index].setVisible(false);
> 90: frames[index].dispose();
Calling `setVisible(false)` before `dispose` is redundant.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26871#discussion_r2299038191
PR Review Comment: https://git.openjdk.org/jdk/pull/26871#discussion_r2299040604
More information about the client-libs-dev
mailing list