RFR: 8365886: JSplitPane loses track of the left component when the component orientation is changed [v3]
Tejesh R
tr at openjdk.org
Tue Aug 26 10:01:37 UTC 2025
On Tue, 26 Aug 2025 09:42:09 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:
>> src/java.desktop/share/classes/javax/swing/JSplitPane.java line 390:
>>
>>> 388: } else {
>>> 389: if (leftComponent != null) {
>>> 390: this.leftComponent = rightComponent;
>>
>> Suggestion:
>>
>> this.leftComponent = leftComponent;
>>
>> Is this by mistake ?
>
> no
This is LEFT_TO_RIGHT orientation right and you are checking `leftComponent != null` and assigning `rightComponent` and vice versa ? Should it be left to left and right to right ?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26893#discussion_r2300470466
More information about the client-libs-dev
mailing list