RFR: 8361521 : BogusFocusableWindowState.java fails with StackOverflowError on Linux [v5]
Anass Baya
abaya at openjdk.org
Thu Aug 28 07:53:30 UTC 2025
On Wed, 27 Aug 2025 18:34:05 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
>> Anass Baya has updated the pull request incrementally with one additional commit since the last revision:
>>
>> add space
>
> src/java.desktop/unix/classes/sun/awt/X11/XWindowPeer.java line 1105:
>
>> 1103: }
>> 1104: promoteDefaultPosition();
>> 1105: boolean refreshChildsTransientFor = isVisible() != vis;
>
> Move the assignment
>
> boolean refreshChildsTransientFor = isVisible() != vis;
>
> before the `if` statement, and use `refreshChildsTransientFor` in the condition to avoid evaluating the same condition twice.
Done
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26298#discussion_r2306537775
More information about the client-libs-dev
mailing list