RFR: 8365609: Fix several potential NULL native pointer dereferences in the desktop module [v2]
Artem Semenov
asemenov at openjdk.org
Thu Aug 28 13:21:47 UTC 2025
On Thu, 28 Aug 2025 12:44:58 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:
>> Artem Semenov has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - Updated fix fore src/java.desktop/unix/native/libawt_xawt/awt/gtk3_interface.c gtk3_load()
>> - Revert "The same issue is present in src/java.desktop/unix/native/libawt_xawt/awt/gtk3_interface.c gtk3_load()"
>>
>> This reverts commit a369e3af3abb11eb1163c1ea461e1558b8838551.
>
> src/java.desktop/share/native/common/java2d/opengl/OGLBlitLoops.c line 325:
>
>> 323: sy, srcInfo->scanStride);
>> 324: if (pf != NULL) {
>> 325: if (slowPath) {
>
> The current indentation does seem to be off.
>
>
> GLvoid *pSrc = PtrCoord(srcInfo->rasBase,
> sx, srcInfo->pixelStride,
> sy, srcInfo->scanStride);
> if (pf) {
> if (slowPath) {
> jint tmph = sh;
> while (tmph > 0) {
> ...
>
>
> The same applies to the other added if statement.
fixed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26799#discussion_r2307395760
More information about the client-libs-dev
mailing list