RFR: 8150564: Migrate useful ExtendedRobot methods into awt.Robot [v2]
Damon Nguyen
dnguyen at openjdk.org
Thu Aug 28 20:25:43 UTC 2025
On Thu, 28 Aug 2025 06:27:41 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Make vars static
>
> src/java.desktop/share/classes/java/awt/Robot.java line 813:
>
>> 811: mousePress(buttons);
>> 812: waitForIdle(20);
>> 813: mouseRelease(buttons);
>
> It would be good to call ***release methods in the finally block.
Is this necessary? Would I have to account for accidentally releasing any buttons that should still be pressed by calling `mouseRelease(buttons)` in a `finally` block if some exception is thrown during `mousePress`?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26969#discussion_r2308455470
More information about the client-libs-dev
mailing list