RFR: 8366369: Add @requires linux for GTK L&F tests
Phil Race
prr at openjdk.org
Thu Aug 28 21:34:46 UTC 2025
On Thu, 28 Aug 2025 18:34:00 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
> * Add `@requires os.family == "linux"` to prevent GTK L&F tests from running on other OS but Linux.
> * Let any exceptions from `UIManager.setLookAndFeel` propagate.
> * Remove `@author` tag.
> * Expand imports in `test/jdk/com/sun/java/swing/plaf/gtk/Test6635110.java`.
> * Add leading asterisks to jtreg comment block.
Marked as reviewed by prr (Reviewer).
test/jdk/com/sun/java/swing/plaf/gtk/4928019/bug4928019.java line 39:
> 37: try {
> 38: UIManager.setLookAndFeel("com.sun.java.swing.plaf.gtk.GTKLookAndFeel");
> 39: } catch (UnsupportedLookAndFeelException ex) {
Just so you know .. this can be thrown on Linux too if the libgtk-3 isn't found.
However since all these tests are headful, it ought to be OK.
-------------
PR Review: https://git.openjdk.org/jdk/pull/26995#pullrequestreview-3166605437
PR Review Comment: https://git.openjdk.org/jdk/pull/26995#discussion_r2308600003
More information about the client-libs-dev
mailing list