RFR: 8366369: Add @requires linux for GTK L&F tests
Prasanta Sadhukhan
psadhukhan at openjdk.org
Fri Aug 29 02:33:41 UTC 2025
On Thu, 28 Aug 2025 18:34:00 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
> * Add `@requires os.family == "linux"` to prevent GTK L&F tests from running on other OS but Linux.
> * Let any exceptions from `UIManager.setLookAndFeel` propagate.
> * Remove `@author` tag.
> * Expand imports in `test/jdk/com/sun/java/swing/plaf/gtk/Test6635110.java`.
> * Add leading asterisks to jtreg comment block.
test/jdk/com/sun/java/swing/plaf/gtk/4928019/bug4928019.java line 37:
> 35: public class bug4928019 {
> 36: public static void main(String[] args) throws Throwable {
> 37: UIManager.setLookAndFeel("com.sun.java.swing.plaf.gtk.GTKLookAndFeel");
WHy to restrict it to only GTK? We can iterate it for all installed L&Fs, no?
We have similar fixes in particular L&F but then extend the test for all L&F just to ensure it works ok for all L&F..
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26995#discussion_r2308972262
More information about the client-libs-dev
mailing list