RFR: 8366359: Test should throw SkippedException when there is no lpstat [v2]

SendaoYan syan at openjdk.org
Fri Aug 29 02:48:37 UTC 2025


On Thu, 28 Aug 2025 22:23:31 GMT, Phil Race <prr at openjdk.org> wrote:

>> SendaoYan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Use "@requires (os.family == "linux")" instead of check OS type in code
>
> test/jdk/javax/print/PrintServiceLookup/CountPrintServices.java line 35:
> 
>> 33:  * @bug 8032693
>> 34:  * @key printer
>> 35:  * @library /test/lib/
> 
> GitHub isn't letting me click to comment on the line I want to but this test looks like another one that should require(os == linux)

Thanks for the suggestion. OS type check in code has been replaced as `@requires (os.family == "linux")`

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26988#discussion_r2308984426


More information about the client-libs-dev mailing list