RFR: 8365609: Fix several potential NULL native pointer dereferences in the desktop module [v4]

[Phil Race]

On Fri, 29 Aug 2025 08:02:30 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Artem Semenov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fixed indentation
>
> src/java.desktop/share/native/common/java2d/opengl/OGLBlitLoops.c line 412:
> 
>> 410:     // in case pixel stride is not a multiple of scanline stride the copy
>> 411:     // has to be done line by line (see 6207877)
>> 412:     if (pf != NULL) {
> 
> https://github.com/openjdk/jdk/blob/c96d09acd95d0ccf2fef50b8ccfeb5e2a0aa0968/src/java.desktop/share/native/common/java2d/opengl/OGLBlitLoops.c#L651
> 
> OGLBlitSwToTexture is called with PixelFormat defined as
> 
> https://github.com/openjdk/jdk/blob/c96d09acd95d0ccf2fef50b8ccfeb5e2a0aa0968/src/java.desktop/share/native/common/java2d/opengl/OGLSurfaceData.c#L52-L76
> 
> which is not null so not sure why pf will ever be null? Did you see it null anytime?

This was discussed already. There's another call site that passes NULL.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26799#discussion_r2310570091