RFR: 8364146: JList getScrollableUnitIncrement return 0 [v10]

Phil Race prr at openjdk.org
Tue Dec 2 20:16:51 UTC 2025


On Tue, 2 Dec 2025 02:50:21 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> It seems JList.getScrollableUnitIncrement can sometime return 0 instead of positive number which is not specified in the javadoc which can lead to confusion. Clarified javadoc as to when it can return 0.
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   javadoc clarify

src/java.desktop/share/classes/javax/swing/JList.java line 2501:

> 2499:      * row (for vertical scrolling) or column (for horizontal scrolling).
> 2500:      * The scrolling distance returned will be positive,
> 2501:      * unless scrolling location for the specified parameters is already

my suggestion was "unless scrolling for".
you changed it to "unless scrolling location for"
I don't think adding the word location here is correct in the overall context of the sentence.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26500#discussion_r2582651737


More information about the client-libs-dev mailing list