RFR: 8371914: PNG defines in CFLAGS can cause compilation errors with external libpng [v2]

[Kurt Miller]

On Wed, 3 Dec 2025 05:41:27 GMT, Jayathirth D V <jdv at openjdk.org> wrote:

>> Kurt Miller has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Clarify comment per code review
>
> make/modules/java.desktop/lib/ClientLibraries.gmk line 174:
> 
>> 172:     endif
>> 173: 
>> 174:     # The external libpng submitted in the jdk is a reduced version
> 
> I think this comment should start with "The libpng bundled with jdk". Mentioning "external" at this level doesn't seem right. Since we are touching this part we can update the comment.

That is more clear for sure.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28324#discussion_r2585649096