RFR: 5107379: Component orientation in JOptionPane is not proper in Motif L&F. [v2]

Prasanta Sadhukhan psadhukhan at openjdk.org
Tue Dec 9 06:11:19 UTC 2025


On Tue, 9 Dec 2025 05:57:14 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Test fix
>
> test/jdk/javax/swing/plaf/motif/TestIconRTL.java line 35:
> 
>> 33: import java.awt.ComponentOrientation;
>> 34: import java.util.HashMap;
>> 35: import java.util.Map;
> 
> Unused imports.

fixed

> test/jdk/javax/swing/plaf/motif/TestIconRTL.java line 44:
> 
>> 42: import javax.swing.SwingUtilities;
>> 43: import javax.swing.UIManager;
>> 44: import javax.swing.UnsupportedLookAndFeelException;
> 
> Unused import.

fixed

> test/jdk/javax/swing/plaf/motif/TestIconRTL.java line 53:
> 
>> 51:     static final String INSTRUCTIONS = """
>> 52:         A JOptionPane is shown in Motif LookAndFeel.
>> 53:         Test with LTR and RTL Orientation
> 
> Adding the instructions on where to change the Orientation would bring more clarity. Since user can change from Menubar, it would be better to add that note.

ok added

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28532#discussion_r2601224916
PR Review Comment: https://git.openjdk.org/jdk/pull/28532#discussion_r2601224697
PR Review Comment: https://git.openjdk.org/jdk/pull/28532#discussion_r2601224575


More information about the client-libs-dev mailing list