RFR: 8372592: Adjust logger usage in java2d tests

Prasanta Sadhukhan psadhukhan at openjdk.org
Fri Dec 12 09:35:00 UTC 2025


On Thu, 11 Dec 2025 22:37:56 GMT, Phil Race <prr at openjdk.org> wrote:

> We had a previous mysterious failure that looks like it was due to a logger being gc'd.
> To prevent that update all the marlin tests to use a logger stored in a static.
> The 'final' modifier probably isn't necessary for this but is harmless, I'm doing the minimum here
> so I don't want to go change log -> LOG everywhere just because its now final.

test/jdk/sun/java2d/marlin/CrashNaNTest.java line 57:

> 55:     static final boolean SAVE_IMAGE = false;
> 56: 
> 57:     // initialize j.u.l Looger:

looger -> logger

test/jdk/sun/java2d/marlin/CrashPaintTest.java line 56:

> 54:     static final boolean SAVE_IMAGE = false;
> 55: 
> 56:     // initialize j.u.l Looger:

same

test/jdk/sun/java2d/marlin/TextClipErrorTest.java line 64:

> 62:     static final boolean SERIALIZE = false;
> 63: 
> 64:     // initialize j.u.l Looger:

same

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28778#discussion_r2613548458
PR Review Comment: https://git.openjdk.org/jdk/pull/28778#discussion_r2613549049
PR Review Comment: https://git.openjdk.org/jdk/pull/28778#discussion_r2613549369


More information about the client-libs-dev mailing list