RFR: 8373474: 2 Unintentional format string defect groups in jabswitch.cpp [v3]
Phil Race
prr at openjdk.org
Mon Dec 22 23:10:54 UTC 2025
On Mon, 22 Dec 2025 22:10:49 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:
>> This issue is not currently causing any problems, but I am adding specifiers to explicitly print these strings. This is to avoid any issues down the line where changes to the lines building the string can cause any accidental formatting. Overall, this should be a harmless update and improves the stability and reliability of printing these strings.
>
> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
>
> Revert
src/jdk.accessibility/windows/native/jabswitch/jabswitch.cpp line 231:
> 229: char str[100] = "assistive_technologies=com.sun.java.accessibility.AccessBridge\n";
> 230: strcat_s(str, "screen_magnifier_present=true\n");
> 231: fprintf(origFile, "%s", str);
That isn't what I meant either.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28949#discussion_r2641485387
More information about the client-libs-dev
mailing list