RFR: 8373475: Unintentional format string in logString of AccessInfo.cpp [v3]

Damon Nguyen dnguyen at openjdk.org
Tue Dec 23 20:40:24 UTC 2025


On Tue, 23 Dec 2025 20:26:53 GMT, Phil Race <prr at openjdk.org> wrote:

>> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fputs and copyright
>
> src/jdk.accessibility/windows/native/toolscommon/AccessInfo.cpp line 100:
> 
>> 98:     vsnprintf(tmpbuf, sizeof(tmpbuf), msg, argprt);
>> 99: 
>> 100:     fputs(tmpbuf, logfile);
> 
> unless I'm missing something you'd need to add a 2nd fputs for the newline or go back to fprintf like before the latest comment.

I have gone back to `fprintf` for consistency as you mentioned above. Newline is included. Thanks!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28950#discussion_r2644208484


More information about the client-libs-dev mailing list