RFR: 8373475: Unintentional format string in logString of AccessInfo.cpp [v3]

Damon Nguyen dnguyen at openjdk.org
Tue Dec 23 20:40:27 UTC 2025


On Tue, 23 Dec 2025 20:23:48 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fputs and copyright
>
> src/jdk.accessibility/windows/native/toolscommon/AccessInfo.cpp line 100:
> 
>> 98:     vsnprintf(tmpbuf, sizeof(tmpbuf), msg, argprt);
>> 99: 
>> 100:     fputs(tmpbuf, logfile);
> 
> Since `fputs` doesn't add a line break automatically, you have to add it explicitly.
> 
> 
>     fputs(tmpbuf, logfile);
>     fputs("\n", logfile);

Thanks for catching this too!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28950#discussion_r2644208958


More information about the client-libs-dev mailing list