RFR: 8348865: JButton/bug4796987.java never runs because Windows XP is unavailable [v2]

[Alexey Ivanov]

On Mon, 3 Feb 2025 06:38:28 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Alexey Ivanov has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Update the test summary
>>  - Remove the redundant button
>
> test/jdk/javax/swing/JButton/4796987/bug4796987.java line 30:
> 
>> 28:  * @requires (os.family == "windows")
>> 29:  * @summary Verify JButton.setBorderPainted(false) removes border
>> 30:  *      for Windows visual styles (Windows XP and later)
> 
> Is it necessary to mention about Windows XP ?

Why not? Visual styles were introduced in Windows XP.

Even though the test was written when both Windows Vista and Windows 7 had already been released, it was limited to Windows XP only for some reason.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23336#discussion_r1939789226