RFR: 8348865: JButton/bug4796987.java never runs because Windows XP is unavailable [v2]

Abhishek Kumar abhiscxk at openjdk.org
Tue Feb 4 05:30:21 UTC 2025


On Fri, 31 Jan 2025 20:40:27 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> The `javax/swing/JButton/4796987/bug4796987.java` test strictly verifies if it's run on Windows XP, for this reason it never runs on modern versions of Windows.
>> 
>> Since Windows XP is obsolete and visual styles cannot be disabled since Windows 8, I removed the OS version check completely.
>> 
>> I captured an image of the panel and analyse colors in the image instead of using `Robot.getPixelColor`; I save the image for reference if the test fails.
>> 
>> The updated test passes in the CI.
>
> Alexey Ivanov has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Update the test summary
>  - Remove the redundant button

LGTM

-------------

Marked as reviewed by abhiscxk (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/23336#pullrequestreview-2591770404


More information about the client-libs-dev mailing list