RFR: 8328977 : JEditorPane.setPage not thread-safe, pageLoader not cancelled [v3]

Alexey Ivanov aivanov at openjdk.org
Tue Feb 4 11:17:16 UTC 2025


On Fri, 19 Apr 2024 14:53:09 GMT, Renjith Kannath Pariyangad <rkannathpari at openjdk.org> wrote:

>> Hi Reviewers,
>> 
>> Added pageloader cancel before new page creation along with code restructuring. Moved all page loading calls inside synchronize to make it thread safe.
>> 
>> Regards,
>> Renjith.
>
> Renjith Kannath Pariyangad has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Rearranged if based on suggesion

I believe it's premature to integrate it right away. At the very least, you should merge master and re-run all the client tests before integrating.

Even though the PR is approved, there's [an unresolved discussion](https://github.com/openjdk/jdk/pull/18670#pullrequestreview-2048663406).

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18670#issuecomment-2633596869


More information about the client-libs-dev mailing list