RFR: 8348760: RadioButton is not shown if JRadioButtonMenuItem is rendered with ImageIcon in WindowsLookAndFeel [v2]

Prasanta Sadhukhan psadhukhan at openjdk.org
Tue Feb 4 11:21:10 UTC 2025


On Tue, 4 Feb 2025 11:09:35 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> test/jdk/javax/swing/JMenuItem/TestImageIconWithJRadioButtonMenuItem.java line 45:
>> 
>>> 43: public class TestImageIconWithJRadioButtonMenuItem {
>>> 44: 
>>> 45:     private static final String instructionsText = """
>> 
>> Suggestion:
>> 
>>     private static final String INSTRUCTIONSTEXT = """
>
> For what it's worth, it should be `INSTRUCTIONS_TEXT` with the underscore separating words.
> 
> It's not required to capitalise private constants, only public constants use all capitals with underscores between words.

FWIW, it is changed to "INSTRUCTIONS" in test..

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23324#discussion_r1940981255


More information about the client-libs-dev mailing list