RFR: 8348760: RadioButton is not shown if JRadioButtonMenuItem is rendered with ImageIcon in WindowsLookAndFeel [v6]
Prasanta Sadhukhan
psadhukhan at openjdk.org
Tue Feb 4 11:42:12 UTC 2025
On Tue, 4 Feb 2025 11:23:52 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
>>> This is why we should re-work the layout of menus with icons if there's any radio- or check-menu item as I [suggested above](https://github.com/openjdk/jdk/pull/23324#discussion_r1935784688).
>>
>> Not sure I understand...As in windows11 Explorer, radiobutton checkmark and icon are at the same position as in jdk..
>> what more you are suggesting to change?
>
> Radio- or checks are in the same position but ***the icon itself** is moved to the right* so that both the bullet or check and the icon are displayed.
>
> Currently, only the icon is rendered at the place where the bullet or checkmark are if there's no icon.
>
> The result should like this
>
> 
>
> instead of
>
> 
>
> It is the former image that corresponds to File Explorer in Windows 11: https://github.com/openjdk/jdk/pull/23324#discussion_r1935744523
But that's what I believe is been done now in the PR test, corresponding to your 1st image and corresponds to windows11

If icon is present, it will be drawn at x+3*OFFSET...and button/checkmark is always drawn at x-OFFSET irrespective of icon
present or not..
Are you suggesting to keep more gap in between checkmark and button?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23324#discussion_r1941010595
More information about the client-libs-dev
mailing list