RFR: 8348760: RadioButton is not shown if JRadioButtonMenuItem is rendered with ImageIcon in WindowsLookAndFeel [v6]
Abhishek Kumar
abhiscxk at openjdk.org
Tue Feb 4 12:51:12 UTC 2025
On Thu, 30 Jan 2025 15:47:26 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:
>> When JRadioButtonMenuItem is called with imageIcon, then only imageIcon is shown without radiobutton in WIndowsLookAndFeel as there was no provision of drawing the radiobutton alongside icon.
>> If icon is not there, the radiobutton is drawn. Added provision of drawing the radiobutton windows Skin even when imageIcon is present.
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>
> Draw checkmark skin at same location with/without icon
> I believe this is likely how layout is calculated.
I just wanted to know "why 3 is chosen as a magic number ?". Actually the spacing with "4 * OFFSET" looks better between radio, icon and text of menu item (on win 11).
-------------
PR Comment: https://git.openjdk.org/jdk/pull/23324#issuecomment-2633809263
More information about the client-libs-dev
mailing list