RFR: JDK-8347377 : Add validation checks for ICC_Profile header fields [v9]

[Phil Race]

On Fri, 31 Jan 2025 10:17:11 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

> > Non-ICC intents are not something we'd support. I see absolutely no problem with that.
> > If a profile has an intent that is unknown to JDK APIs, it doesn't matter what LCMS might do with it
> > if you were programming directly to LCMS as a CMM.
> 
> non-cc intents in lcms are just examples of profiles in the wild that don't violate the icc spec, currently such profiles can be loaded and used for conversion, this patch will break that. Why we should apply this limit and do that now?
> 
> Note that it is possible to use custom intents as well, and we will break it:
> 
> > Little CMS plug-in architecture allows to implement user-defined intents
> 
> > Who knows how many things we'd have to do in order to support 'custom' ICC intents.
> 
> Then let's at least not break it intentionally. Then test and fix if it does not work.

I am 100% for breaking it. We should never have allowed it.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/23044#issuecomment-2637833734