RFR: 8347826: Introspector shows wrong method list after 8071693 [v3]

Alexander Zvegintsev azvegint at openjdk.org
Thu Feb 6 13:16:10 UTC 2025


On Tue, 4 Feb 2025 16:28:51 GMT, Roman Marchenko <rmarchenko at openjdk.org> wrote:

>> Fixed `com.sun.beans.introspect.MethodInfo#MethodOrder` to make `Introspector.addMethod()` working properly when filtering methods out.
>> 
>> Also fixed the test, and added the approptiate test case.
>
> Roman Marchenko has updated the pull request incrementally with one additional commit since the last revision:
> 
>   minor test fix

Looks good.

test/jdk/java/beans/Introspector/DefaultMethodBeanPropertyTest.java line 152:

> 150:         );
> 151:     }
> 152: 

Suggestion:


//////////////////////////////////////
//                                  //
//          SCENARIO 4              //
//                                  //
//////////////////////////////////////



I think this can be added for consistency with the rest of the test.

-------------

Marked as reviewed by azvegint (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/23443#pullrequestreview-2598637065
PR Review Comment: https://git.openjdk.org/jdk/pull/23443#discussion_r1944702211


More information about the client-libs-dev mailing list