RFR: 8348760: RadioButton is not shown if JRadioButtonMenuItem is rendered with ImageIcon in WindowsLookAndFeel [v9]

Prasanta Sadhukhan psadhukhan at openjdk.org
Fri Feb 7 03:30:18 UTC 2025


On Tue, 4 Feb 2025 14:16:16 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> When JRadioButtonMenuItem is called with imageIcon, then only imageIcon is shown without radiobutton in WIndowsLookAndFeel as there was no provision of drawing the radiobutton alongside icon.
>> If icon is not there, the radiobutton is drawn. Added provision of drawing the radiobutton windows Skin even when imageIcon is present.
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   retain diff of OFFSET between skin background start coord and skin coordinate

skin =  xp.getSkin(c, backgroundPart);
                            skin.paintSkin(g, x - 2 * OFFSET, y,
                                getIconWidth(), getIconHeight(), backgroundState);
                            skinWidth = getIconWidth();

@aivanov-jdk  Can you please check if we use getIconWidth() instead of skin.getWidth, does the icon stay clear of the bullet/checkmark background skin in windows 10?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/23324#issuecomment-2641846800


More information about the client-libs-dev mailing list