RFR: 8349350: Unable to print using InputSlot and OutputBin print attributes at the same time
GennadiyKrivoshein
duke at openjdk.org
Fri Feb 7 08:11:10 UTC 2025
On Fri, 7 Feb 2025 07:38:30 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:
>> Fix for https://bugs.openjdk.org/browse/JDK-8349350. It's impossible to use more that one print option.
>>
>> **Reason of the bug**:
>> execCmd array uses one index per print flag, but 'OPTIONS' flag can use two indexes for the options.
>>
>> **Fix description**:
>> make the size of the execCmd array dependent on the number of options.
>>
>> **Test**:
>> new test PrintExecCmdOptionTest.java created to check execution with multiple options. (run on MacOS, Windows and linux x86_64)
>
> src/java.desktop/share/classes/sun/print/PSPrinterJob.java line 1578:
>
>> 1576: }
>> 1577: if (options != null && !options.isEmpty()) {
>> 1578: optionArgs = options.trim().split("\\s+");
>
> In what format the options are expected for this regex to work? Is it same for both linux and mac?
The format is space delimited values, each value is a "key=value".
There is no difference between Linux and Mac and there are no changes in the format of the options.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23457#discussion_r1946119634
More information about the client-libs-dev
mailing list