RFR: 8348760: RadioButton is not shown if JRadioButtonMenuItem is rendered with ImageIcon in WindowsLookAndFeel [v10]
Alexey Ivanov
aivanov at openjdk.org
Fri Feb 7 19:13:14 UTC 2025
On Fri, 7 Feb 2025 05:26:10 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:
>> When JRadioButtonMenuItem is called with imageIcon, then only imageIcon is shown without radiobutton in WIndowsLookAndFeel as there was no provision of drawing the radiobutton alongside icon.
>> If icon is not there, the radiobutton is drawn. Added provision of drawing the radiobutton windows Skin even when imageIcon is present.
>
> Prasanta Sadhukhan has updated the pull request incrementally with two additional commits since the last revision:
>
> - remove test file
> - Move text position w.r.t menuItem icon
This is how it looks on Windows 10:

It's close, yet the spacing is wrong.
The bullet / check-mark should be where they were before the fix. There was 8-pixel margin to the left of selected bullet background before the fix, now there are only 2 pixels.
The margin between the bullet background and the text was again 8 pixels, I think we should maintain the same margin between the bullet and the icon as well as between the icon and the menu text.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/23324#issuecomment-2643787270
More information about the client-libs-dev
mailing list