RFR: 8348760: RadioButton is not shown if JRadioButtonMenuItem is rendered with ImageIcon in WindowsLookAndFeel [v10]

Prasanta Sadhukhan psadhukhan at openjdk.org
Mon Feb 10 05:27:20 UTC 2025


On Fri, 7 Feb 2025 19:09:21 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Prasanta Sadhukhan has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - remove test file
>>  - Move text position w.r.t menuItem icon
>
> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicMenuItemUI.java line 662:
> 
>> 660:         paintCheckIcon(g, lh, lr, holdc, foreground);
>> 661:         paintIcon(g, lh, lr, holdc);
>> 662:         if (UIManager.getLookAndFeel().getName().equals("Windows")
> 
> Can't this be handled in `WindowsMenuItemUI` instead? After all, Metal and Windows L&F looked differently.

I tried but Many a thing cannot be accessed outside plaf.basic package and I am checking for WIndows L&F so Metal will not be affected..

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23324#discussion_r1948412121


More information about the client-libs-dev mailing list