RFR: 8347826: Introspector shows wrong method list after 8071693 [v4]

Roman Marchenko rmarchenko at openjdk.org
Mon Feb 10 10:21:13 UTC 2025


On Thu, 6 Feb 2025 14:13:50 GMT, Roman Marchenko <rmarchenko at openjdk.org> wrote:

>> Fixed `com.sun.beans.introspect.MethodInfo#MethodOrder` to make `Introspector.addMethod()` working properly when filtering methods out.
>> 
>> Also fixed the test, and added the approptiate test case.
>
> Roman Marchenko has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update test/jdk/java/beans/Introspector/DefaultMethodBeanPropertyTest.java
>   
>   Co-authored-by: Aleksandr Zvegintsev <77687766+azvegint at users.noreply.github.com>

> it would be nice to update the code that retrieves the method from that list, or at least provide some information why we can't  do that.
> Example from the past #7190 where MethodOrder was simplified due to JDK-8196373 do that.

@mrserb Sorry, I don't feel I completely understand what are you asking for. What do you mean "the code that retrieves the method from that list"? Should I add comments somewhere in source code with the issue details why does Introspector.addMethod() work wrong for now, or with details about sorting? Or should I update the PR description? I couldn't find any clues in #7190, sorry.

And BTW, I'm concerning why I can't find a check in this PR which builds and tests the change. Should I trigger it somehow, or is it just invisible for me?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/23443#issuecomment-2647539955


More information about the client-libs-dev mailing list