RFR: 8208377: Soft hyphens render if not using TextLayout [v3]
Alisen Chung
achung at openjdk.org
Mon Feb 10 19:36:15 UTC 2025
On Fri, 20 Dec 2024 00:17:54 GMT, Daniel Gredler <dgredler at openjdk.org> wrote:
>> Soft hyphens should never render, regardless of the rendering path used internally.
>>
>> This PR does not expand the categorization of "complex" characters in `FontUtilities` in order to force the use of `TextLayout` rendering code paths (as was discussed in JBS).
>>
>> Instead, it takes the existing (limited) format-category checks in `sun.font.CMap` (a TrueType font helper class), expands it to a more general / complete default-ignorable check (`FontUtilities.isDefaultIgnorable(int)`), and then moves these checks out of `CMap` and up a level into the `CharToGlyphMapper` classes themselves.
>>
>> The Type1 glyph mapper, the TTF glyph mapper, and the macOS glyph mapper have all been updated.
>
> Daniel Gredler has updated the pull request incrementally with one additional commit since the last revision:
>
> Add more info about test fonts and default-ignorable chars
src/java.desktop/macosx/classes/sun/font/CCharToGlyphMapper.java line 2:
> 1: /*
> 2: * Copyright (c) 2011, 2024, Oracle and/or its affiliates. All rights reserved.
2025 now since it's the new year
src/java.desktop/share/classes/sun/font/Type1GlyphMapper.java line 2:
> 1: /*
> 2: * Copyright (c) 2003, 2024, Oracle and/or its affiliates. All rights reserved.
new year here too
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22670#discussion_r1949763888
PR Review Comment: https://git.openjdk.org/jdk/pull/22670#discussion_r1949764852
More information about the client-libs-dev
mailing list