RFR: JDK-8348302 : [Test bug] Update FileDialogIconTest.java [v3]
Tejesh R
tr at openjdk.org
Tue Feb 11 08:00:15 UTC 2025
On Fri, 7 Feb 2025 22:20:26 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:
>> FileDialogIconTest.java has been updated.
>>
>> Following changes were made.
>>
>> - Test instructions updated
>> - BugID associated with the test is updated to the correct one
>> - setIconBufferedImagesToFrame and setIconBufferedImagesToDialog btns added to the frame.
>> - other minor cleanups
>
> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
>
> minor
As per my testing and understanding (correct me if I'm wrong)
1. `setIconImageToFrame` button set the icon of Frame to Java image.
2. `setIconBufferedImagesToFrame` button sets captured image to icon for both JFrame and also Dialogs. (As you have mentioned in JBS comments and also from [JDK-6425126](https://bugs.openjdk.org/browse/JDK-6425126))
3. Apart from these two buttons I don't see any actions for other buttons (including setting icon image buttons for Dialog).
Can you please update the test instructions mentioning about the icon matching with both JFrame and JDialog once its set.
-------------
PR Review: https://git.openjdk.org/jdk/pull/23523#pullrequestreview-2607941452
More information about the client-libs-dev
mailing list