RFR: 8349350: Unable to print using InputSlot and OutputBin print attributes at the same time [v2]

GennadiyKrivoshein duke at openjdk.org
Thu Feb 13 13:55:11 UTC 2025


On Tue, 11 Feb 2025 21:43:53 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

>> GennadiyKrivoshein has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   replace regexp s+ with space
>
> src/java.desktop/share/classes/sun/print/PSPrinterJob.java line 1641:
> 
>> 1639:                 execCmd[n++] = "-o job-sheets=standard";
>> 1640:             }
>> 1641:             if (optionArgs != null) {
> 
> I see this block is the same in both branches of the if condition. Can we just move it outside the condition to keep it simpler?

Yes, these are the same blocks, thanks. I moved options after the if condition.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23457#discussion_r1954540443


More information about the client-libs-dev mailing list