RFR: 8349351 : Combine Screen Inset Tests into a Single File [v2]
Damon Nguyen
dnguyen at openjdk.org
Thu Feb 13 17:51:11 UTC 2025
On Sun, 9 Feb 2025 19:56:48 GMT, anass baya <duke at openjdk.org> wrote:
>> While working on [JDK-6899304](https://bugs.openjdk.org/browse/JDK-6899304), we discovered that there are two tests meant to perform the same task.
>>
>> The first test is located at test/jdk/java/awt/Multiscreen/MultiScreenInsetsTest/MultiScreenInsetsTest.java and was originally designed for multi-screen configurations on Linux platforms.
>>
>> The second test, located at test/jdk/java/awt/Toolkit/ScreenInsetsTest/ScreenInsetsTest.java, is intended for single-screen configurations but lacks accuracy due to some workarounds to support Windows.
>>
>> Now, the test at test/jdk/java/awt/Multiscreen/MultiScreenInsetsTest/MultiScreenInsetsTest.java has been updated to work across all platforms, including Windows, which was previously failing. As a result, it has been agreed to rename this test to ScreenInsetsTest, remove the condition that restricted its execution to multi-screen configurations, and remove the redundant test at test/jdk/java/awt/Toolkit/ScreenInsetsTest/ScreenInsetsTest.java.
>
> anass baya has updated the pull request incrementally with one additional commit since the last revision:
>
> Add proposed enhancments
Ran the test with repeats on all OS's. Seems good to me. I tried playing with the tolerance values a bit, and I think the tolerance here seems fine.
-------------
Marked as reviewed by dnguyen (Committer).
PR Review: https://git.openjdk.org/jdk/pull/23449#pullrequestreview-2615818132
More information about the client-libs-dev
mailing list