RFR: 8349351 : Combine Screen Inset Tests into a Single File [v2]

Harshitha Onkar honkar at openjdk.org
Thu Feb 13 18:08:15 UTC 2025


On Fri, 7 Feb 2025 19:30:48 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> If it test runs fine on CI then it should be okay. Previously, I came across few tests which required increasing tolerance value (although not in this context but particularly for pixel color case).
>
> Tolerance when comparing colours is different from comparing sizes.
> 
> We know that fractional pixels after scaling up and down may be lost, that's where the tolerance comes from.

@aivanov-jdk 
> We know that fractional pixels after scaling up and down may be lost, that's where the tolerance comes from.

You are right, scaling up and down a fractional pixel can be at most be off by one pixel.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23449#discussion_r1954993246


More information about the client-libs-dev mailing list