RFR: JDK-8346465 : Add a check in setData() to restrict the update of Built-In ICC_Profiles [v2]

[Harshitha Onkar]

On Thu, 13 Feb 2025 21:36:21 GMT, Phil Race <prr at openjdk.org> wrote:

>> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   javadoc update
>
> src/java.desktop/share/classes/java/awt/color/ICC_Profile.java line 1165:
> 
>> 1163:      *         the {@code tagSignature}
>> 1164:      * @throws IllegalArgumentException if the profile being updated has
>> 1165:      *         {@code isBuiltIn} flag set to true
> 
> isBuiltin is a private variable. You can't reference it in public API javadoc.
> 
> What this ought to say is
> @throw IllegalArgumentException if this is a profile for one of the built-in pre-defined ColorSpaces, i.e those which can be obtained by calling ICC_Profile.getInstance(int cspace) 
> 
> There isn't a general way to get that list - but it is short - only 5 colour spaces, and you could put an @see ColorSpace link

Thanks Phil. Updated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23606#discussion_r1955264291