RFR: 8160327: Support for thumbnails present in APP1 marker for JPEG [v2]
Brian Burkhalter
bpb at openjdk.org
Fri Feb 14 21:11:13 UTC 2025
On Thu, 2 Jan 2025 06:49:19 GMT, Jeremy <duke at openjdk.org> wrote:
>> This adds support for parsing thumbnails in an APP1 Exif marker.
>>
>> This builds on an unfinished proposal by Brian Burkhalter (around 2016). In that previous work the only additional meta info he parsed was the image creation time; this PR similarly includes the same property. (I can't speak to why he included that property, but it looks like he has a lot of experience with ImageIO so I trust his judgment.)
>>
>> The test addresses the original images attached to the ticket plus a few extra images I found on my computer that include unusual properties. (Possibly those images are malformed, but if they exist in the wild and other platforms support them then I'd prefer to support them too.)
>
> Jeremy has updated the pull request incrementally with one additional commit since the last revision:
>
> 8160327: fixing typo so `thumbnailPos` can be zero
>
> The `thumbnailLength` cannot be zero, but the position can be.
src/java.desktop/share/classes/com/sun/imageio/plugins/jpeg/ExifMarkerSegment.java line 28:
> 26: package com.sun.imageio.plugins.jpeg;
> 27:
> 28: import java.io.InputStream;
I suggest putting the imports on lines 28-51 in alphabetical order.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22898#discussion_r1956718373
More information about the client-libs-dev
mailing list