RFR: JDK-8346465 : Add a check in setData() to restrict the update of Built-In ICC_Profiles [v2]

Jayathirth D V jdv at openjdk.org
Mon Feb 17 05:55:11 UTC 2025


On Thu, 13 Feb 2025 22:00:26 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   javadoc update
>
> src/java.desktop/share/classes/java/awt/color/ICC_Profile.java line 1154:
> 
>> 1152:      * This method is useful for advanced applications which need to access
>> 1153:      * profile data directly. Only non-BuiltIn profiles can be updated using
>> 1154:      * this method.
> 
> @prrace 
> I added this additional line here mentioning that only non-BuiltIn profiles can be updated. Does it look okay or do you recommend any changes ?

I think here also language should be similar to what we use in `@throws IllegalArgumentException`. Using just "non-BuiltIn profiles" doesn't give full picture.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23606#discussion_r1957652578


More information about the client-libs-dev mailing list