Integrated: 8348865: JButton/bug4796987.java never runs because Windows XP is unavailable
Alexey Ivanov
aivanov at openjdk.org
Mon Feb 17 13:16:20 UTC 2025
On Tue, 28 Jan 2025 14:51:57 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
> The `javax/swing/JButton/4796987/bug4796987.java` test strictly verifies if it's run on Windows XP, for this reason it never runs on modern versions of Windows.
>
> Since Windows XP is obsolete and visual styles cannot be disabled since Windows 8, I removed the OS version check completely.
>
> I captured an image of the panel and analyse colors in the image instead of using `Robot.getPixelColor`; I save the image for reference if the test fails.
>
> The updated test passes in the CI.
This pull request has now been integrated.
Changeset: 650d0d95
Author: Alexey Ivanov <aivanov at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/650d0d954ea8e20e31f17d459993d5edecf08a4c
Stats: 82 lines in 1 file changed: 45 ins; 15 del; 22 mod
8348865: JButton/bug4796987.java never runs because Windows XP is unavailable
Reviewed-by: tr, abhiscxk, serb
-------------
PR: https://git.openjdk.org/jdk/pull/23336
More information about the client-libs-dev
mailing list