RFR: JDK-8346465 : Add a check in setData() to restrict the update of Built-In ICC_Profiles [v5]

[Harshitha Onkar]

On Thu, 20 Feb 2025 14:40:00 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   javadoc change
>
> src/java.desktop/share/classes/java/awt/color/ICC_Profile.java line 1154:
> 
>> 1152:      * This method is useful for advanced applications which need to access
>> 1153:      * profile data directly. Only non-built-in, application provided profiles
>> 1154:      * should be updated using this method.
> 
> What you mean is that only non-built-in profiles *can* be updated. The fix makes it impossible to update built-in profiles.

I'll be inverting this statement to state what is NOT allowed rather than what is allowed by .setData() as below. Does the following sound better?


     * Note: JDK built-in ICC Profiles cannot be updated using this method
     * as it will result in IAE. JDK built-in profiles are those obtained by
     * {@code ICC_Profile.getInstance(int colorSpaceID)} where colorSpaceID
     * is one of the following:
     * {@link ColorSpace#CS_sRGB}, {@link ColorSpace#CS_LINEAR_RGB},
     * {@link ColorSpace#CS_PYCC}, {@link ColorSpace#CS_GRAY} or
     * {@link ColorSpace#CS_CIEXYZ}

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23606#discussion_r1964129561