RFR: JDK-8346465 : Add a check in setData() to restrict the update of Built-In ICC_Profiles [v5]
Harshitha Onkar
honkar at openjdk.org
Fri Feb 21 00:56:57 UTC 2025
On Thu, 20 Feb 2025 18:26:03 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
>> I'll be inverting this statement to state what is NOT allowed rather than what is allowed by .setData() as below. Does the following sound better?
>>
>>
>> * Note: JDK built-in ICC Profiles cannot be updated using this method
>> * as it will result in IAE. JDK built-in profiles are those obtained by
>> * {@code ICC_Profile.getInstance(int colorSpaceID)} where colorSpaceID
>> * is one of the following:
>> * {@link ColorSpace#CS_sRGB}, {@link ColorSpace#CS_LINEAR_RGB},
>> * {@link ColorSpace#CS_PYCC}, {@link ColorSpace#CS_GRAY} or
>> * {@link ColorSpace#CS_CIEXYZ}
>
> This is clearer.
Looks like my previous commit was not reflected. I have update it now.
@prrace Updated PR and CSR.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23606#discussion_r1964583365
More information about the client-libs-dev
mailing list