RFR: 8349932: PSPrinterJob sometimes generates unnecessary PostScript commands [v2]

[Alisen Chung]

On Fri, 14 Feb 2025 23:51:49 GMT, Daniel Gredler <dgredler at openjdk.org> wrote:

>> Trying to print text which is ignored (e.g. `\r` or `\n` or `\t`), or trying to print empty shapes generates PostScript graphics context setup commands which are not necessary. This can lead to unnecessarily large PostScript files, and can complicate analysis / comparison of these files.
>> 
>> Two methods are impacted:
>> 
>> `PSPrinterJob.textOut(...)`: The `prepDrawing()` method should only be called once all sanity checks have passed. Otherwise, it will add PS graphics context setup commands that may not be necessary.
>> 
>> `PSPrinterJob.deviceFill(...)`: This method should do nothing if the provided `PathIterator` is empty. Otherwise, it will add PS graphics context setup commands that are not necessary.
>> 
>> The changes in `PSPrinterJob.textOut(...)` eliminated a big `if` statement, therefore include some indentation changes. Checking the diff with whitespace ignored should be helpful here.
>> 
>> A test case is included.
>
> Daniel Gredler has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Consider OS line separator when inspecting PostScript

test passing on macos, changes look good

-------------

Marked as reviewed by achung (Committer).

PR Review: https://git.openjdk.org/jdk/pull/23595#pullrequestreview-2634478219