RFR: 8348760: RadioButton is not shown if JRadioButtonMenuItem is rendered with ImageIcon in WindowsLookAndFeel [v14]
Prasanta Sadhukhan
psadhukhan at openjdk.org
Mon Feb 24 08:21:48 UTC 2025
> When JRadioButtonMenuItem is called with imageIcon, then only imageIcon is shown without radiobutton in WIndowsLookAndFeel as there was no provision of drawing the radiobutton alongside icon.
> If icon is not there, the radiobutton is drawn. Added provision of drawing the radiobutton windows Skin even when imageIcon is present.
Prasanta Sadhukhan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 18 additional commits since the last revision:
- Merge branch 'master' of https://git.openjdk.java.net/jdk into JDK-8348760
- comment
- Extend to Windows11 and later
- Restore Windows 10 behavior
- remove test file
- Move text position w.r.t menuItem icon
- retain diff of OFFSET between skin background start coord and skin coordinate
- remove debug
- Move icon w.r.t bullet skin width
- Move icon w.r.t bullet skin width
- ... and 8 more: https://git.openjdk.org/jdk/compare/613d6d1d...7f0849fc
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/23324/files
- new: https://git.openjdk.org/jdk/pull/23324/files/7cb51be9..7f0849fc
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=23324&range=13
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=23324&range=12-13
Stats: 227049 lines in 5308 files changed: 112131 ins; 91591 del; 23327 mod
Patch: https://git.openjdk.org/jdk/pull/23324.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/23324/head:pull/23324
PR: https://git.openjdk.org/jdk/pull/23324
More information about the client-libs-dev
mailing list