RFR: JDK-8346465 : Add a check in setData() to restrict the update of Built-In ICC_Profiles [v6]

Harshitha Onkar honkar at openjdk.org
Mon Feb 24 19:40:55 UTC 2025


On Mon, 24 Feb 2025 19:20:00 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> src/java.desktop/share/classes/java/awt/color/ICC_Profile.java line 116:
>> 
>>> 114:      * BuiltInProfile.
>>> 115:      */
>>> 116:     private boolean isBuiltIn = false;
>> 
>> Should the field be named `builtIn` instead? `isBuiltIn` starts with a verb which is used for naming methods.
>
> IIRC we usually have `is` or `has` prefixed to boolean vars as per naming convention?

You are right, probably fields are named without the prefix and methods/local vars are prefixed with 'is'.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23606#discussion_r1968312788


More information about the client-libs-dev mailing list