RFR: 8349350: Unable to print using InputSlot and OutputBin print attributes at the same time [v4]
GennadiyKrivoshein
duke at openjdk.org
Tue Feb 25 14:55:41 UTC 2025
> Fix for https://bugs.openjdk.org/browse/JDK-8349350. It's impossible to use more that one print option.
>
> **Reason of the bug**:
> execCmd array uses one index per print flag, but 'OPTIONS' flag can use two indexes for the options.
>
> **Fix description**:
> make the size of the execCmd array dependent on the number of options.
>
> **Test**:
> new test PrintExecCmdOptionTest.java created to check execution with multiple options. (run on MacOS, Windows and linux x86_64)
GennadiyKrivoshein has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
- Merge branch 'openjdk:master' into print_options_idx_out_of_rng
- remove code duplication
- replace regexp s+ with space
- use array for option args
- Fix ArrayIndexOutOfBoundsException at PSPrinterJob printExecCmd
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/23457/files
- new: https://git.openjdk.org/jdk/pull/23457/files/621bf2e0..291ed330
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=23457&range=03
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=23457&range=02-03
Stats: 35998 lines in 1329 files changed: 19973 ins; 10576 del; 5449 mod
Patch: https://git.openjdk.org/jdk/pull/23457.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/23457/head:pull/23457
PR: https://git.openjdk.org/jdk/pull/23457
More information about the client-libs-dev
mailing list