RFR: 8303904: [macos]Transparent Windows Paint Wrong (Opaque, Pixelated) w/o Volatile Buffering [v3]
Jeremy
duke at openjdk.org
Wed Feb 26 18:58:04 UTC 2025
On Mon, 24 Feb 2025 08:41:47 GMT, anass baya <duke at openjdk.org> wrote:
>> The PR includes two fix :
>> 1 - The first fix targets proper rendering of the transparent image.
>> 2 - The second fix ensures the image is painted at the correct resolution to avoid pixelation.
>
> anass baya has updated the pull request incrementally with three additional commits since the last revision:
>
> - Enhancment step 3
> - Enhancement - step 2
> - enhancement - step 1
Looks good to me (note I'm not an official OpenJDK reviewer). I'm not a fan of the `instanceof Graphics2D` check, but any alternative I propose would be more lines of code so I accept this is good enough.
src/java.desktop/macosx/classes/sun/lwawt/LWComponentPeer.java line 28:
> 26: package sun.lwawt;
> 27:
> 28: import java.awt.*;
I know in other PRs reviewers have asked to expand wildcard imports. (I haven't studied that topic closely enough to have an informed opinion.)
-------------
Marked as reviewed by mickleness at github.com (no known OpenJDK username).
PR Review: https://git.openjdk.org/jdk/pull/23430#pullrequestreview-2645537315
PR Review Comment: https://git.openjdk.org/jdk/pull/23430#discussion_r1972182225
More information about the client-libs-dev
mailing list