RFR: 8347826: Introspector shows wrong method list after 8071693 [v7]

Sergey Bylokhov serb at openjdk.org
Fri Feb 28 04:02:59 UTC 2025


On Thu, 27 Feb 2025 11:29:37 GMT, Roman Marchenko <rmarchenko at openjdk.org> wrote:

>> Roman Marchenko has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Symmetric fix
>
> src/java.desktop/share/classes/com/sun/beans/introspect/PropertyInfo.java line 98:
> 
>> 96:                     writeType = info.type;
>> 97:                 } else if (writeType.isAssignableFrom(info.type)) {
>> 98:                     if ((this.write == null) || (!info.method.isDefault() && this.write.type.isAssignableFrom(info.type))) {
> 
> I cannot reproduce this because of the sorting, however it's reproduced without sorting.
> Added this to make the fix symmetric between read/write properties.

Do we always want to drop default methods here, or should we accept them if the "current method" is also a default method(or null)?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23443#discussion_r1974728330


More information about the client-libs-dev mailing list