RFR: 8346846 : Open source PageRangesException.java test

Alexey Ivanov aivanov at openjdk.org
Fri Jan 3 13:47:46 UTC 2025


On Fri, 3 Jan 2025 04:47:41 GMT, Renjith Kannath Pariyangad <rkannathpari at openjdk.org> wrote:

> Hi All,
> 
> I have updated the test and made it automation friendly. Please review and let me know your suggestions

Looks good to me except for minor comments.

test/jdk/javax/print/attribute/PageRangesException.java line 2:

> 1: /*
> 2:  * Copyright (c) 2001, 2024, Oracle and/or its affiliates. All rights reserved.

Suggestion:

 * Copyright (c) 2001, 2025, Oracle and/or its affiliates. All rights reserved.

The year should be 2025 now.

test/jdk/javax/print/attribute/PageRangesException.java line 44:

> 42:         }
> 43: 
> 44:         //test 4433096

Suggestion:

        // test 4433096

For consistency.

-------------

Marked as reviewed by aivanov (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/22909#pullrequestreview-2529105119
PR Review Comment: https://git.openjdk.org/jdk/pull/22909#discussion_r1901798977
PR Review Comment: https://git.openjdk.org/jdk/pull/22909#discussion_r1901798404


More information about the client-libs-dev mailing list