RFR: 8282862: AwtWindow::SetIconData leaks old icon handles if an exception is detected

Rajat Mahajan rmahajan at openjdk.org
Mon Jan 6 17:43:07 UTC 2025


**Issue:** 
AwtWindow::SetIconData leaks the old icon handles in hOldIcon and hOldIconSm if CreateIconFromRaster raises an exception. Additionally, an exception is checked only after the first call to CreateIconFromRaster.

**Solution:**
I have added the exception handling code to take care that the handles are properly destroyed and not leaked.

**Testing:**
I have tested the code to make sure there are no regressions caused by this.

-------------

Commit messages:
 - 8282862: AwtWindow::SetIconData leaks old icon handles if an exception is detected

Changes: https://git.openjdk.org/jdk/pull/22932/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22932&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8282862
  Stats: 13 lines in 1 file changed: 10 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/jdk/pull/22932.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/22932/head:pull/22932

PR: https://git.openjdk.org/jdk/pull/22932


More information about the client-libs-dev mailing list