RFR: 8342870: Errors related to unused code on Windows after 8339120 in accessibility [v2]

[Julian Waters]

On Tue, 19 Nov 2024 17:58:59 GMT, Phil Race <prr at openjdk.org> wrote:

>> Julian Waters has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>> 
>>  - Remove now unused result
>>  - Merge branch 'master' into accessibility
>>  - 8342870
>
> There's not much I like about this PR. I think it would be better to withdraw it and submit a bug against A11Y for people to look at what should really be done about these cases. Which could include "do nothing".

@prrace I've tried to fix up the code changes here to look as neat as possible, but ultimately I'm not sure what you want it to look like. Could you explain why you don't like the changes in accessibility? Unlike the corresponding awt changes which are more complex and even touch the C++ Standard, the Pull Request here consists purely of marking unused code for removal, which shouldn't be too bad at least in my opinion, which is why I'm not sure why you don't like it

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21656#issuecomment-2574861271